-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for keyboard shortcut selecting text across multiple blocks #43164
Add documentation for keyboard shortcut selecting text across multiple blocks #43164
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bengreeley! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating these docs @bengreeley 👍
The new sections appear as advertised for me. I have a couple of small nits that I've left as inline comments. I believe with those tweaks the wording will be a touch more accurate and this will be ready to merge.
What do you think?
packages/block-editor/src/components/keyboard-shortcuts/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies @bengreeley, this one slipped through the cracks of my notifications backlog 😅
I've retested this locally, after rebasing on trunk, and the documentation for selecting text across multiple blocks appears in both locations as advertised.
We might need to rebase this PR branch if re-running the failed tests doesn't get them passing. The failures appear to be unrelated to the changes in this PR.
Thanks for rebasing @aaronrobertshaw! It's been on my to-do list as well but haven't gotten around to it. Appreciate you taking a look! |
Co-authored-by: Aaron Robertshaw <[email protected]>
Co-authored-by: Aaron Robertshaw <[email protected]>
9d2d0ef
to
15a3c07
Compare
I've rebased this PR and will merge once the tests pass |
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
What?
Addresses #41168, implementing documentation for the keyboard shortcut for selecting text across multiple blocks (without selecting all of a blocks' text). Feature was originally implemented in #38892.
How?
Adds missing documentation on selecting text between blocks to editor 'Keyboard shortcuts' modal and the 'Are there keyboard shortcuts for Gutenberg' documentation.
Testing Instructions