Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: Replace react-dates and moment with useLilius and date-fns #43005

Merged
merged 10 commits into from
Aug 16, 2022
Merged

DateTimePicker: Replace react-dates and moment with useLilius and date-fns #43005

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e38c45a
DateTimePicker: Replace react-dates and moment with useLilius and dat…
noisysocks Jul 22, 2022
eb5dff2
Remove moment and react-dates dependencies
noisysocks Aug 5, 2022
9dd1fc1
Memoize label
noisysocks Aug 5, 2022
1aa8e27
Better RTL support
noisysocks Aug 5, 2022
34849a1
Better label localisation
noisysocks Aug 5, 2022
1951ead
Try to explain focus logic
noisysocks Aug 5, 2022
f3e5050
Add Wrapper back to TimePicker
noisysocks Aug 5, 2022
6100300
Update CHANGELOG
noisysocks Aug 5, 2022
5066945
Update post-visiblity and switch-to-draft e2e tests
noisysocks Aug 5, 2022
acb5c1d
Merge branch 'trunk' into update/replace-moment-and-react-dates-from-…
noisysocks Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
418 changes: 26 additions & 392 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@

- `Flex`, `FlexItem`, `FlexBlock`: Convert to TypeScript ([#42537](https://github.com/WordPress/gutenberg/pull/42537)).
- `InputControl`: Fix incorrect `size` prop passing ([#42793](https://github.com/WordPress/gutenberg/pull/42793)).
- `Popover`: rewrite Storybook examples using controls [#42903](https://github.com/WordPress/gutenberg/pull/42903)).
- `Popover`: rewrite Storybook examples using controls ([#42903](https://github.com/WordPress/gutenberg/pull/42903)).
- `DateTimePicker`, `TimePicker`, `DatePicker`: Switch from `moment` to `date-fns` ([#43005](https://github.com/WordPress/gutenberg/pull/43005)).
- `DatePicker`: Switch from `react-dates` to `use-lilius` ([#43005](https://github.com/WordPress/gutenberg/pull/43005)).

## 19.16.0 (2022-07-27)

Expand Down
4 changes: 2 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@
"@wordpress/warning": "file:../warning",
"classnames": "^2.3.1",
"colord": "^2.7.0",
"date-fns": "^2.28.0",
"dom-scroll-into-view": "^1.2.1",
"downshift": "^6.0.15",
"framer-motion": "^6.2.8",
"gradient-parser": "^0.1.5",
"highlight-words-core": "^1.2.2",
"lodash": "^4.17.21",
"memize": "^1.1.0",
"moment": "^2.26.0",
"re-resizable": "^6.4.0",
"react-colorful": "^5.3.1",
"react-dates": "^21.8.0",
"reakit": "^1.3.8",
"remove-accents": "^0.4.2",
"use-lilius": "^2.0.1",
noisysocks marked this conversation as resolved.
Show resolved Hide resolved
"uuid": "^8.3.0"
},
"peerDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/date-time/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const TIMEZONELESS_FORMAT = "yyyy-MM-dd'T'HH:mm:ss";
5 changes: 3 additions & 2 deletions packages/components/src/date-time/date-time/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { CalendarHelp } from './styles';
import { HStack } from '../../h-stack';
import { Heading } from '../../heading';
import { Spacer } from '../../spacer';
import { VStack } from '../../v-stack';

export { DatePicker, TimePicker };

Expand Down Expand Up @@ -63,7 +64,7 @@ function UnforwardedDateTimePicker(
}

return (
<div ref={ ref } className="components-datetime">
<VStack ref={ ref } className="components-datetime" spacing={ 4 }>
{ ! calendarHelpIsVisible && (
<>
<TimePicker
Expand Down Expand Up @@ -186,7 +187,7 @@ function UnforwardedDateTimePicker(
) }
</HStack>
) }
</div>
</VStack>
);
}

Expand Down
Loading