Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset focalPoint after replacing the cover image #42859

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Reset focalPoint after replacing the cover image #42859

merged 1 commit into from
Aug 10, 2022

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Aug 1, 2022 •
edited by stokesman
Loading

What?

Reset the focalPoint value after replacing image media on the cover block.

Resolves #28859

Testing Instructions

Follow the video instructions:

fix.bug.-.2022-08-01.12-40-05.mp4

@paulopmt1 paulopmt1 requested a review from ajitbohra as a code owner August 1, 2022 15:41
@paulopmt1 paulopmt1 changed the title Reset focalPoint after replacing the cover image #28859 Reset focalPoint after replacing the cover image Aug 1, 2022
@paulopmt1
Copy link
Contributor Author

The test packages/e2e-tests/specs/editor/plugins/wp-editor-meta-box.test.js is passing on my local:

image

stokesman
stokesman approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@stokesman stokesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! The change makes sense and I've tested to verify it works.

@stokesman stokesman added the [Package] Block library /packages/block-library label Aug 2, 2022
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Aug 2, 2022
@Mamaduka Mamaduka merged commit c3f19c4 into WordPress:trunk Aug 10, 2022
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 10, 2022
@paulopmt1 paulopmt1 deleted the update/28859-reset-focalPoint-on-replacing-images branch August 10, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stokesman stokesman stokesman approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.

Cover Block: Make Focus Settings Image-Specific
3 participants
@paulopmt1 @stokesman @Mamaduka