Change shortcut text for redo tooltip on Windows #42830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Focus] Accessibility (a11y)
t-hamano
requested review from
draganescu,
talldan,
tellthemachines,
adamziel,
kevin940726,
getdave and
noisysocks
as code owners
|
Size Change: +810 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
What do you think about only displaying Ctrl+Y in the tooltip on Windows since that's the default shortcut for Redo in Windows? (Both shortcuts can continue to work.) |
|
This may be a matter of opinion, but I believe both should be indicated. As seen in the following article, there are many applications that have historically adopted For example, in Adobe products, Perhaps different users have different perceptions, so I think it would be better to explicitly indicate that both commands are supported in gutenberg (as both are shown in the keyboard shortcut modal). |
|
I also think it's ok just to display 'Ctrl+Y' in the tooltip. Though both can be in the shortcut modal. I think most Windows applications will just use Ctrl+Y, even though there is some inconsistency. There's also some precedence - GSuite shows only Ctrl+Y as the shortcut, though both Ctrl+Shift+Z and Ctrl+Y work. |
|
Okay, then I will change the policy to replace the current |
t-hamano
changed the title
|
Thanks @t-hamano! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #42627
What?
This PR adds Ctrl+Y text for redo tooltip on Windows.This PR changes the shortcut text for redo tooltip from
Ctrl + Shift + ZtoCtrl + Yon Windows.Why?
In #42627, a new shortcut
Ctrl + Yhas been added on Windows.It was correctly displayed in the keyboard modal window but was not included in the tooltip when the Redo button was focused.
How?
I considered simply separating the text with a slash, but I ran it through asprintffunction because the meaning may not be conveyed in some languages.I replaced it with
Ctrl+Y, which is the default redo command in Windows.Testing Instructions
These tooptips are shown in following 5 area.
On Macs, please make sure the text has not changed.
Post Editor
Site Editor
Widget Editor
Customizer
Edit Navigation
I couldn't figure out how to access this, but I believe it should appear correctly.