FIX - Links: Can't add plain text after insert link at end of paragraph #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
This makes sense and resolves the issue where creating a new paragraph split from inside a code block keeps code styling.
Still all of the "Also behaves quite strangely where:" points are problematic from #1246 (comment), but can be addressed separately. Do you want me to create standalone issues for them?
|
@aduth I should have mentioned that I'm still looking at the other issues. I think what needs to happen is that when the split occurs right before the inline boundary character that it needs to stay with the 'before' nodes... |
gziolo
added
the
[Status] Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expanded the test for link boundaries to include any type of inline boundary by testing for the presence of the '\uFEFF' character in the text content.
fixes: #1246
How Has This Been Tested?
Manually in browser
Screenshots (jpeg or gifs if applicable):
Types of changes
Bug fix
Checklist: