Disabled: migrate to TypeScript #42708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -48 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Type] Enhancement
walbo
reviewed
Aug 3, 2022
walbo
reviewed
Aug 8, 2022
ciampo
reviewed
Aug 8, 2022
|
Thanks for the review. I will update Unit test to ts as well. Will ping you when done! |
torounit
force-pushed
the
refactoring/components/disabled
branch
from
3b0e5fc to
3bfe8c9
Compare
torounit
commented
Aug 18, 2022
torounit
commented
Aug 18, 2022
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Petter Walbø Johnsgård <[email protected]>
Co-authored-by: Petter Walbø Johnsgård <[email protected]>
Alright, let's treat it as a bug — we'll try to trace when it was introduced and work on a fix + unit tests. |
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
… into refactoring/components/disabled # Conflicts: # packages/components/src/disabled/test/index.tsx
The approach looks promising, but let's work on it in a separate PR to keep this one focused on the TypeScript migration. Would you be able to remove 28820f0 from this PR and open a new PR with that fix instead? Once that's done and CHANGELOG conflicts are solved, we should be able to merge this one 🚀 |
ciampo
reviewed
Aug 22, 2022
ciampo
reviewed
Aug 23, 2022
ciampo
reviewed
Aug 23, 2022
ciampo
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Converts the
Disabledcomponent to TypeScript.Testing Instructions
npm run storybook:devDisabledScreenshots or screencast