-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid reliance on status constants when consuming useCreateNavigationMenu hook #42704
Merged
getdave
merged 2 commits into
trunk
from
update/avoid-constants-when-consuming-create-nav-menu-hook
Jul 29, 2022
Merged
Avoid reliance on status constants when consuming useCreateNavigationMenu hook #42704
getdave
merged 2 commits into
trunk
from
update/avoid-constants-when-consuming-create-nav-menu-hook
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Block] Navigation
Affects the Navigation Block
labels
Jul 26, 2022
Size Change: +134 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jul 27, 2022
getdave
commented
Jul 27, 2022
packages/block-library/src/navigation/edit/use-create-navigation-menu.js
Outdated
Show resolved
Hide resolved
scruffian
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
getdave
deleted the
update/avoid-constants-when-consuming-create-nav-menu-hook
branch
July 29, 2022 07:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR exports named vars from the hook to avoid consumers having to rely on string comparison with constants defined within the hook file.
Why?
Reasons:
How?
Exports named vars for the various statuses instead of asking developers to compare string values of the
status
with hard coded constants.This:
...becomes
Testing Instructions
Screenshots or screencast