remove deprecated eslint rules

[kkmuffme]

their replacements are already added (es5.js no-unsafe-negation) or are enabled by default already (jsx-11y label-has-associated-control)

What?

Remove deprecated eslint rules

Why?

Bc they're deprecated

How?

Remove code from config

Testing Instructions

Run eslint with the given config. There is no change in output, since eslint silently ignored the rules already.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kkmuffme! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[gziolo]

Great catch, thank you for the fix.

[github-actions]

Congratulations on your first merged pull request, @kkmuffme! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[afercia]

Worth noting the configuration of the new label-has-associated-control is not equivalent to the one of the previous label-has-for, where it was required to associate labels to inputs by using for/id attributes. As established long time ago, we avoid wrapping labels because old assistive technology may not fully support that.

Will create a follow-up.

[kkmuffme]

Definitely. But since that old rule was deprecated for a while now, and the new rule label-has-associated-control is enabled by default with the default config, it means eslint ran with the default config for this rule for months now anyway. This is why I didn't add a specific config as we had before, since the default config has been used now for quite some time.

[desrosj]

@kkmuffme While collecting props and credits for 6.1, it seems you are one of a few dozen folks that have not connected their WordPress.org account to their GitHub profile.

Could you share your WordPress.org account so that we can ensure you're properly credited on the About page for WordPress 6.1? Connecting your accounts will also help those collecting this in the future. Thanks in advance!

[kkmuffme]

Please credit me with my Github username thx.

[desrosj]

@kkmuffme Unfortunately the way attribution is given for WordPress releases is strictly through wordpress.org accounts. The credits API does not differentiate between credit sources (ie. GitHub, wordpress.org, etc.).

It looks like the same username is unregistered on wordpress.org if you'd like to just use the same username.

[kkmuffme]

Thanks, created the account now and linked it to the Github account.