Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme.json: Add support for heading / caption elements in theme.json schema #42433

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Theme.json: Add support for heading / caption elements in theme.json schema #42433

merged 1 commit into from
Jul 20, 2022

Conversation

t-hamano
Copy link
Contributor

Fix: #42313

The following PRs have added global style support for the heading and caption elements:

We now need to update the schema for theme.json to reflect this accurately.

@t-hamano t-hamano added [Block] Heading Affects the Headings Block Developer Experience Ideas about improving block and theme developer experience labels Jul 14, 2022
@t-hamano t-hamano requested a review from ajlende as a code owner July 14, 2022 13:33
@t-hamano t-hamano mentioned this pull request Jul 14, 2022
Closed
carolinan
carolinan approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thank you.

@carolinan carolinan merged commit 1d79d2c into trunk Jul 20, 2022
@carolinan carolinan deleted the add/schema-theme-elements-missing branch July 20, 2022 10:04
@github-actions github-actions bot added this to the Gutenberg 13.8 milestone Jul 20, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Aug 4, 2022
@bph bph mentioned this pull request Oct 3, 2022
Closed
89 tasks
@yaseenaljamal yaseenaljamal mentioned this pull request Jan 31, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 31, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 1, 2024
Open
@yassine4999 yassine4999 mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees
No one assigned
Labels
[Block] Heading Affects the Headings Block Developer Experience Ideas about improving block and theme developer experience Needs Dev Note Requires a developer note for a major WordPress release cycle
Projects
None yet
Milestone
Gutenberg 13.8
Development

Successfully merging this pull request may close these issues.

Heading element is not included in theme.json
3 participants
@t-hamano @carolinan @bph