Hide prefix and suffix placeholders in post terms #42418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Block] Categories
ajlende
requested review from
adamziel,
scruffian,
getdave,
mtias,
mikachan,
MaggieCabrera and
dmsnell
|
Size Change: +9 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
dmsnell
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Looks like a straightforward and appropriate approach to solving this.
Not part of this PR but it's curious that we have __( 'Prefix' ) + ' ' below for the placeholder. I assume that's to solve some graphical glitch but I also assume in RTL scripts that unintentionally adds space before the placeholder when we wanted it after
carolinan
approved these changes
Jul 20, 2022
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides the prefix and suffix when the block is not selected so it matches what is shown in save.
Why?
Fixes #42318
How?
Hides the prefix and suffix placeholders when the block is not selected.
Testing Instructions
Screenshots or screencast
Co-authored-by: Dave Smith [email protected]