Components: Refactor ExternalLink away from Lodash
#42341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
mirka,
aristath,
gziolo,
swissspidy,
ciampo,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
tyxla
force-pushed
the
refactor/external-link-lodash
branch
from
6eba462 to
5afe649
Compare
tyxla
force-pushed
the
refactor/external-link-lodash
branch
from
5afe649 to
e19ab83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
ExternalLinkcomponent. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We have to deal essentially a couple of methods, and migration away from them is pretty straightforward:
compact()We're replacing it with a
filter( Boolean ).uniq()We're replacing it with
[ ...new Set( originalArray ) ].Testing Instructions
npm run storybook:devExternalLinkrelattribute as before in the demo.