Components: Remove Lodash from DropdownMenu
#42218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
mirka,
aristath,
gziolo,
swissspidy,
ciampo,
geriux,
pinarol,
mkevins,
chad1008,
andrewserong,
ntsekouras and
fabiankaegy
fabiankaegy
reviewed
Jul 7, 2022
|
Size Change: +4 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-dropdown-menu
branch
from
242097f to
0a31dcc
Compare
mirka
reviewed
Jul 8, 2022
| if ( control.onClick ) { | ||
| control.onClick(); | ||
| { controlSets | ||
| ?.map( ( controlSet, indexOfSet ) => |
tyxla
force-pushed
the
remove/lodash-dropdown-menu
branch
from
0a31dcc to
cfb94a9
Compare
tyxla
force-pushed
the
remove/lodash-dropdown-menu
branch
from
82d0d88 to
8c1d275
Compare
tyxla
force-pushed
the
remove/lodash-dropdown-menu
branch
from
8c1d275 to
d9af5c1
Compare
tyxla
force-pushed
the
remove/lodash-dropdown-menu
branch
from
d9af5c1 to
663f4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
DropdownMenucomponent. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We have to deal essentially a couple of methods, and migration away from them is pretty straightforward:
flatMap()We're replacing it with a
map()on the arrays, followed by a.flat()to flatten the result array.isEmpty()Since the usage is for arrays, ensuring they're not nullish and have
.lengthis a substantial replacement.Testing Instructions
npm run test-unit packages/components/src/dropdown-menu.