-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show autosave message when autosave exists #4218
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
cc1a856
Rework PR 4218
c6d5cce
Merge branch 'master' of github.com:WordPress/gutenberg
3baae76
Merge branch 'master' into feature/heartbeat-autosaving
3444476
switch to withDispatch approach
ebe5dd4
fixes for eslint
045fd0f
remove unneeded braces
c97b109
REQUEST_AUTOSAVE_NOTICE: bail early if autosaveStatus is falsey
fb0988e
remove unused autosave reducer
68f0754
whitespace
4f2832c
Merge branch 'master' into feature/heartbeat-autosaving
9194bb7
remove field change check when retrieving autosave newer than post
5f816d1
cleanup, doc blcoks
95cb823
exit early if autosave false
80768f1
Merge branch 'master' into feature/heartbeat-autosaving
f625239
add missing simicolon
3e5e744
Merge branch 'master' of github.com:WordPress/gutenberg
9e97fed
Merge branch 'master' into feature/heartbeat-autosaving
cf9dd40
Merge branch 'master' of github.com:WordPress/gutenberg
f1991ad
Merge branch 'master' of github.com:WordPress/gutenberg
fb512ce
Merge branch 'master' of github.com:WordPress/gutenberg
171c511
Merge branch 'master' of github.com:WordPress/gutenberg
bdab38b
Merge branch 'master' into feature/heartbeat-autosaving
6323b25
spacing cleanup
fcd3d61
fix for eslint
5ceca78
Remove useless spans
youknowriad 216dd49
Merge remote-tracking branch 'origin/master' into feature/heartbeat-a…
youknowriad 52c75a5
Drop the showAutoSaveMessage action
youknowriad 2054d34
Fix unit tests after removing the span
youknowriad 0c0f8d3
Rename autosaveStatus property just "autosave"
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be done through the API. Why do we need the two "get" endpoints for autosaves? They are really pointless if we can't get the latest autosave revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, we could do this with the API instead, good suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(once the API includes the ability to retrieve autosaves 😄 )