Social Links: Set the default protocol to 'https' if not specified #42167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #21699.
Alternative to #30100.
PR tries to use
https
as the default protocol if the URL doesn't appear to contain schema and it's not a relative link starting with //.Why?
If URL has no schema
esc_url
, prepend it withhttp://
. All social media platforms usehttps://
, so it makes sense to be the default fallback.How?
I've used slightly modified logic from
esc_url
. Schema is checked usingparse_url
and code only checks for relative links with//
prefix.Testing Instructions
Snippet
Screenshots or screencast