Performance: Avoid calculating html block styles in useSelect #42026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Performance
|
Size Change: +45 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jun 29, 2022
| store as blockEditorStore, | ||
| } from '@wordpress/block-editor'; | ||
| import { SandBox } from '@wordpress/components'; | ||
|
|
There was a problem hiding this comment.
Oh no, and I finally got the tests passing. 😄
Thanks for the review.
talldan
changed the title
talldan
changed the title
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41618
That issue notes that when the HTML block is present in the editor, it continually performs expensive style calculations, even when it isn't the selected block.
Why?
The issue is that the expensive function call is being made in
useSelect, which is being triggered on every render.How?
In this PR I've changed the code so that
useSelectis used only to get styles from the editor settings. Computation is only performed with auseMemohook, which will only re-trigger if the styles change.The styles are also only used for the preview, so I've moved that into a separate component, and now styles will also only be calculated when the preview is active.
Testing Instructions
Testing that there are no regressions requires using dev tools to inspect the block
trunkversion of Gutenberg open an editorcomponents-sandboxiframe. Expand theheadelement of that iframe and take a look at the stylesheetsTo test the performance improvement, the simplest way is to use a logpoint or similar while an html block is present in a post and then carry out normal editing tasks.