-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic Block: Remove CSS properties with vendor prefixes #41995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Block] Classic
Affects the Classic Editor Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
labels
Jun 28, 2022
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't see box-sizing
used with vendor prefixes in other places.
Thanks, @t-hamano!
mburridge
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Sep 13, 2022
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Classic
Affects the Classic Editor Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
Needs Dev Note
Requires a developer note for a major WordPress release cycle
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR removes CSS properties with vendor prefixes from the classic block.
I think it isn't necessary to explicitly specify properties with vendor prefixes for
box-sizing
.