Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setting registration into WP 6.0 compat #41985

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Mamaduka
Copy link
Member

What?

PR moves site setting registration from WP 5.9 to 6.0 compat directory.

P.S. I'll have core backport PR ready for tomorrow as well - #38607 (comment).

Why?

WP 6.0 compat is the correct directory.

Testing Instructions

  1. Open a Post or Page.
  2. Run this snippet in the DevTools console - wp.data.select('core').getEntityRecord( 'root', 'site' );
  3. Confirm that settings are still returned.

Screenshots or screencast

CleanShot 2022-06-27 at 21 40 03

@Mamaduka Mamaduka requested a review from spacedmonkey as a code owner June 27, 2022 17:46
@Mamaduka Mamaduka self-assigned this Jun 27, 2022
@Mamaduka Mamaduka added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Jun 27, 2022
@Mamaduka Mamaduka requested review from gziolo and aristath June 27, 2022 17:47
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Mamaduka Mamaduka merged commit 069566f into trunk Jun 28, 2022
@Mamaduka Mamaduka deleted the fix/more-setting-registration branch June 28, 2022 07:47
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants