Lodash: Remove completely from @wordpress/shortcode package
#41983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +11 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/shortcodepackage, including thelodashdependency altogether. There are just a few usages and conversion is pretty straightforward. Feel free to review commit-by-commit if it makes it easier - I've tried to keep commits atomic.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're dealing with straightforwardly replacing a few methods, namely:
extendWe're replacing this with the native
Object.assign(), which does the same job in all the affected instances. We're also deprecating this function, because this is its last usage.pickWe're using simple destructuring and creating a new object from the destructured properties.
isStringReplacing this is a simple as using
typeof x === 'string'.isEqualisEqual()is commonly a complex function, especially when deep comparing, however here that's not the case. Here we compare two one-dimensional arrays, with 2 elements each, so it's pretty easy to replace this with a.lengthcomparison, followed by a.every()call that verifies that each element is the same.forEachReplacing
forEach()with the nativeArray.prototype.forEach(), and we useObject.entries()where necessary to convert from object to array in order to be able to iterate it.Testing Instructions
npm run test-unit packages/shortcode