Lodash: Remove completely from @wordpress/keyboard-shortcuts package
#41969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
aristath,
gziolo,
swissspidy,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: -11 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
chad1008
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/keyboard-shortcutspackage, including thelodashdependency altogether. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're dealing with straightforwardly replacing a few methods, namely:
compactOne of the most straightforward conversions when it's called with arrays - we can just replace it with
Array.prototype.filter( Boolean ).omitWe're using destructuring with rest props, which nicely handles the omission.
Testing Instructions
This is not very straightforward to test, as unregistering the keyboard shortcuts requires manual modifications to trigger. However, you can verify that keyboard shortcuts within the customizer block widgets still work well.