Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local dev notes to aid when doing work on schemas #41968

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jun 27, 2022

What?

Update the docs to explain how to do local dev on the schemas.

Why?

This information was missing from the docs and I had to work it out myself.

How?

Provides information on setting your theme.json to point at a local schema rather than the "hosted" version.

Testing Instructions

  • Read docs
  • Try following the instructions to see if you can get the changes to your local schema to be reflected in a theme.json file.

Screenshots or screencast

@getdave getdave self-assigned this Jun 27, 2022
@getdave getdave requested review from ajlende and scruffian June 27, 2022 10:18
@getdave getdave added the [Type] Developer Documentation Documentation for developers label Jun 27, 2022
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@getdave
Copy link
Contributor Author

getdave commented Jun 28, 2022

The failing test is

Navigation › Permission based restrictions

I know that this is unrelated to this PR and is being addressed separately. As this PR makes not changes to code I'm going to force merge.

@getdave getdave merged commit cddece7 into trunk Jun 28, 2022
@getdave getdave deleted the update/schemas-docs-with-local-dev-instructions branch June 28, 2022 09:06
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants