Migrate table block tests to Playwright #41945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Type] Automated Testing
|
Size Change: +40 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
add/playwright-editor-table-test
branch
from
f86db2c to
ed7f216
Compare
t-hamano
changed the title
talldan
reviewed
Jun 27, 2022
|
Thanks for your review!
|
kevin940726
reviewed
Jun 28, 2022
I thought that too, but I don't see any easy way to avoid them. It is hard to look at the snapshots to determine if they're correct, because they're very complex. On the other hand, it's also hard to make assertions that a table is correct (that it has the right number of sections, rows and columns, and the right content in each cell). Snapshots definitely seem like the easiest way, the alternatives will probably be a bit convoluted (i.e. counting the number of cells in each row.) |
|
How about cheking the content string directly by Here is an example code: gutenberg/test/e2e/specs/editor/blocks/buttons.spec.js Lines 16 to 24 in 286e6be |
|
I'm thinking of creating a snapshot-like helper specifically for this test suite: // GFM-style
await expect.poll( tableBlock.visualize ).toBe(
`
| This | Is | Table | Block |
`
);
// Unicode-style
await expect.poll( tableBlock.visualize ).toBe(
`
┌──────┬────┬───────┬───────┐
│ This │ Is │ Table │ Block │
└──────┴────┴───────┴───────┘
`
);So it's snapshot-like, but readable and not that detailed and complex. It might be too much work for a simple test like this though 😅. |
|
A better idea might be using visual comparison directly. But it requires architectural changes (running the browser in a docker environment). It might be worth the efforts in the long run though. |
|
@kevin940726 |
kevin940726
approved these changes
Jun 28, 2022
|
Thank you so much for checking out the details 😀 |
|
Nice work @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate
table.test.jsto Playwright.Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions