Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema support for styles.filter.duotone #41920

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

georgeh
Copy link
Contributor

@georgeh georgeh commented Jun 23, 2022

What?

Add styles.filter.duotone to theme.json Schema

Closes #40398

Why?

This ensures that themes using the Duotone filter property will be able to validate correctly.

Testing Instructions

  1. Create a theme.json with a duotone filter, ex:
{
  "$schema": "https://schemas.wp.org/trunk/theme.json",
  "version": 2,
  "styles": {
    "filter": {
      "duotone": "value"
    }
  }
}
  1. Use a JSON schema validator to confirm it validates with no errors

Screenshots or screencast

N/A

@georgeh georgeh requested a review from ajlende as a code owner June 23, 2022 20:10
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one suggestion and one thing to think about.

schemas/json/theme.json Outdated Show resolved Hide resolved
schemas/json/theme.json Show resolved Hide resolved
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the update to the .md reference and this looks good to go

@Mamaduka
Copy link
Member

Mamaduka commented Jun 27, 2022

Hi, @georgeh

I think failing static analysis check is related to the changes.

There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!

@Mamaduka Mamaduka merged commit 286e6be into trunk Jun 27, 2022
@Mamaduka Mamaduka deleted the fix/theme-schema-filter-duotone branch June 27, 2022 16:56
@Mamaduka
Copy link
Member

Thanks, @georgeh 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styles.filter does not validate against theme.json schema
3 participants