Pasting: Fix performance regression due to removeWindowsFragments #41907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Feature] Paste
[Type] Performance
|
Size Change: +36 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jun 23, 2022
ntsekouras
approved these changes
Jun 23, 2022
|
The failing Static Analysis checks should be resolved now - #41916. |
Fixes #41826. removeWindowsFragments was running two String#replace with regular expressions made computationally expensive due to the use of `.*` and the `s / dotAll` flag, resulting in severe performance degradations when handling larger strings of HTML. The solution is to manually trim the strings via a combination of String#indexOf and String#substring.
mcsf
force-pushed
the
fix/performance-remove-window-fragments
branch
from
e04f76f to
8826fdc
Compare
Thanks! Rebased. |
Mamaduka
added
the
Backport to WP Minor Release
|
Thank you. TIL something important 🙇♂️ |
|
Thanks for the fix! It might be worth commenting within the function that this is a hot path and can affect pasting performance for all, hence the importance of being extra lean in operations. |
adamziel
pushed a commit
that referenced
this pull request
Jun 30, 2022
…1907) * Pasting: Fix performance regression due to removeWindowsFragments Fixes #41826. removeWindowsFragments was running two String#replace with regular expressions made computationally expensive due to the use of `.*` and the `s / dotAll` flag, resulting in severe performance degradations when handling larger strings of HTML. The solution is to manually trim the strings via a combination of String#indexOf and String#substring. * removeWindowsFragments: bail early if no StartFragment found
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: ae46fef |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41826.
Alternative to #41881.
In RichText's
usePasteHandler,removeWindowsFragmentswas running twoString#replacewith regular expressions made computationally expensive due to the use of.*and thes / dotAllflag, resulting in severe performance degradations when handling larger strings of HTML.The solution is to manually trim the strings via a combination of
String#indexOfandString#substring.Testing Instructions
See parent issue, #41826, confirm that pasting is now reasonably fast (~ 1s) for the attached sample.