Make the site editor header toolbar use the ARIA toolbar pattern #41902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[a11y] Keyboard & Focus
[Feature] Site Editor
|
Size Change: +355 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
This is awesome, will check this out shortly. |
alexstine
approved these changes
Jun 28, 2022
alexstine
added
the
[Focus] Accessibility (a11y)
alexstine
added
[Package] Edit Site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41869
What?
Improves accessibility by making the header toolbar in the Site Editor use the ARIA toolbar pattern. This is consistent with other similar toolbars, e.g. the header toolbar in the Block Editor, in the Edit widgets, Edit navigation, etc.
Why?
The header toolbar in the Site Editor has a different keyboard interaction model compared to other similar toolbars. Also, has different semantics.
How?
<NavigableToolbar>component, similarly to the header in the post editor and other toolbars.<ToolbarItem>components. This is necessary to determine whether the toolbar is an 'accessible toolbar' that uses the<Toolbar>component.<Toolbar>component. add some different styles to the buttons, so it was necessary to adjust the CSS. These changes are basically copied from the styles used for the edit post toolbar, seepackages/edit-post/src/components/header/header-toolbar/style.scss. These changes also improve consistency.Testing Instructions
Right arrowto move to the next button.Left arrowto move to the previous button.Endto move to the last button.Hometo move to the first button.Fn + Left arrow, End isFn + Right arrow.Check the style:
Note: at some viewport widths, the overall header in the Site Editor would need some work but this is out of the scope of this issue.
Screenshots or screencast