-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format Library: Add keyboard shortcut for inline code #41816
Conversation
Size Change: +67 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it LGTM 👍🏻
The shortcut works, and it shows up in the help modal.
The code also LGTM, but I'm not really close enough to Gutenberg to approve that, so someone else should take a look too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, nice one!
3d54561
to
cac9275
Compare
What?
Resolves #41796.
PR adds keyboard shortcuts for the "Inline code" format -
ctrl-alt-x
on MacOS andalt-shift-x
on Windows/Linux, as described on the Keyboards Shortcuts support page.PR also updates keyboard shortcuts help modal to display the new option.
How?
Added
RichTextShortcut
to the inline code's edit component.Testing Instructions