Try to fix the image rotating flaky test #41808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Jun 21, 2022
kevin940726
force-pushed
the
fix/image-rotate-flaky-test
branch
from
83615af
to
516b8fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hopefully fix #36904.
Why?
Hopefully fix #36904.
How?
By using
expect.pollto wait for the assertion to succeed. It's a simple yet effective method to redo an assertion until it passes. My best guess of why it's flaky is that the editor hasn't yet finished applying the rotating effects when we made the assertion.Testing Instructions