Block Library (Avatar Block): Remove Unnecessary '&& check' as 'optional chaining (authorDetails?.avatar_urls) check' is already used #41779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hz-tyfoon! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
cbravobernal
added
[Block] Avatar
cbravobernal
approved these changes
Jun 17, 2022
aristath
approved these changes
Jun 17, 2022
Thanks. 🙂 |
alexstine
approved these changes
Jun 18, 2022
Cool. Thanks @alexstine. 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Everyone, This is my first PR. Please review it. 🙂
What?
In line number 81 & 85, There's
&&check forauthorDetailsand then optional chaining (?.) is used. Looks like using both of them together is unnecessary.Just only using
authorDetails && authorDetails.avatar_urlswithout the 'optional chaining (?)' is enough.Or Just only using the latter check like
authorDetails?.avatar_urlsis also enough. (I did this one in my PR)Why?
In the scenario where
authorDetailsisnullorundefined, just using the optional chaining check like this:authorDetails?.avatar_urlswill prevent any error and will return 'undefined'. So, in that scenario there won't be any error and also asConditional (ternary) operatoris used foravatarUrls&sizes, both of this will benull(won't cause any error).