-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to "Good First Review" issues in README #41754
Fix link to "Good First Review" issues in README #41754
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mcliwanow! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort; the good first review link should be for pull requests and go to https://github.com/WordPress/gutenberg/pulls?q=is%3Aopen+is%3Apr+label%3A%22Good+First+Review%22
"Good First Review" text in README file was pointing to issues with label "Good First Issue".
683a98b
to
01e4352
Compare
I feel a little bit embarrassed now 😬 😉 Thanks for pointing that out @skorasaurus ! I have updated code and PR description accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the new link and it works as expected :) Thanks for your contribution! :)
Congratulations on your first merged pull request, @mcliwanow! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
This PR fixes URL of the "Good First Review" link. Previously, it pointed to open issues with label "Good First Issue". After changes it's pointing to open reviews with label "Good First Review".
Why?
I was going through docs for contributors and when I clicked the "Good First Review" link I noticed it took me to the wrong page so I decided to fix it. It's not a biggie and I hope to contribute in a more meaningful way in the future :)
How?
Nothing fancy, just updated URL of the link in README file.
Testing Instructions
.md
files then:docs/contributors/code/README.md
in Preview mode