Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to "Good First Review" issues in README #41754

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

mcliwanow
Copy link
Contributor

@mcliwanow mcliwanow commented Jun 15, 2022

What?

This PR fixes URL of the "Good First Review" link. Previously, it pointed to open issues with label "Good First Issue". After changes it's pointing to open reviews with label "Good First Review".

Why?

I was going through docs for contributors and when I clicked the "Good First Review" link I noticed it took me to the wrong page so I decided to fix it. It's not a biggie and I hope to contribute in a more meaningful way in the future :)

How?

Nothing fancy, just updated URL of the link in README file.

Testing Instructions

  1. Check if the link to "Good First Review" filter works correctly from Github:
  1. If your IDE support Previewing .md files then:
  • Checkout branch from this PR on your machine
  • Open file docs/contributors/code/README.md in Preview mode
  • Click the "Good First Review" link
  • Verify that you are taken to open reviews for the Gutenberg repository and that label "Good First Review" is selected

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mcliwanow! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 15, 2022
Copy link
Member

@skorasaurus skorasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort; the good first review link should be for pull requests and go to https://github.com/WordPress/gutenberg/pulls?q=is%3Aopen+is%3Apr+label%3A%22Good+First+Review%22

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jun 15, 2022
@glendaviesnz glendaviesnz added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jun 16, 2022
"Good First Review" text in README file was pointing to issues with label "Good First Issue".
@mcliwanow mcliwanow force-pushed the fix/link-to-good-first-review branch from 683a98b to 01e4352 Compare June 16, 2022 06:14
@mcliwanow
Copy link
Contributor Author

the good first review link should be for pull requests and go to https://github.com/WordPress/gutenberg/pulls?q=is%3Aopen+is%3Apr+label%3A%22Good+First+Review%22

I feel a little bit embarrassed now 😬 😉 Thanks for pointing that out @skorasaurus ! I have updated code and PR description accordingly.

@mcliwanow mcliwanow requested a review from skorasaurus June 16, 2022 06:19
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new link and it works as expected :) Thanks for your contribution! :)

@Mamaduka Mamaduka merged commit 48e96d5 into WordPress:trunk Jun 16, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @mcliwanow! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants