-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List block v2: Transform don't take into account nested blocks #41741
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/list-block-v2-transform-inner-items
Jun 23, 2022
Merged
List block v2: Transform don't take into account nested blocks #41741
jorgefilipecosta
merged 1 commit into
trunk
from
fix/list-block-v2-transform-inner-items
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
[Block] List
Affects the List Block
labels
Jun 15, 2022
Size Change: +24 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jorgefilipecosta
changed the title
List block v2: Fix impossible to outdent multiple list items.
List block v2: Transform don't take into account nested blocks
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #39879
This PR makes sure indented items on list v2 block are kept during paragraph, headings, quote, and pull-quote transforms.
Testing Instructions
I created a list block with a complex structure and multiple list items.
I tried the four block transforms ( paragraph, headings, quote, and pull-quote ) and verified in all the cases nested items were kept.