-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing-library deps to latest version #41710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
ciampo
added
Framework
Issues related to broader framework topics, especially as it relates to javascript
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
labels
Jun 14, 2022
gziolo
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on packages update 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Framework
Issues related to broader framework topics, especially as it relates to javascript
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Build Tooling
Issues or PRs related to build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update Testing Library dependencies:
@testing-library/jest-dom
: from5.16.1
to5.16.4
@testing-library/react
: from11.2.2
to12.1.5
(note: version 12 is the last one to support React 17)@testing-library/react-native
: from9.0.0
to9.1.0
@testing-library/user-event
: from14.1.1
to14.2.0
All updates should be minor/patch version bumps, apart from
@testing-library/react
— although I had a look at the release notes and the only breaking change introduced inv12
seems to be the update to@testing-library/dom@8
. I had a look at the breaking changes listed in there, and I couldn't find anything that could affect the code in this repo.Why?
In order to enjoy the latest features and bug fixes (see, for example, #41668 (comment))
Testing Instructions