Lodash: Refactor away from _.isFunction()
#41703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
mirka,
swissspidy,
ciampo,
chad1008,
ntsekouras and
fabiankaegy
tyxla
requested review from
gziolo,
adamsilverstein,
ajitbohra,
ellatrix and
nerrad
as code owners
|
Size Change: -11 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
isFunction()is used only a few times in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
isFunction()is straightforward and fully safe in favor of atypeof === functioncheck. Where we had multiple usages in the same file, we're extracting it to a simple function to keep the changes simple and reusable.It's also easy to spot that the
@wordpress/reusable-blockspackage no longer needs thelodashdependency after this PR, so we're also removing that dependency from the package.Testing Instructions