-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash: Refactor away from _.isObjectLike()
#41701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
Related to performance efforts
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Core data
/packages/core-data
[Package] Blocks
/packages/blocks
labels
Jun 14, 2022
tyxla
requested review from
gziolo,
swissspidy,
chad1008,
ntsekouras and
fabiankaegy
June 14, 2022 04:42
Size Change: -7 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jun 14, 2022
tyxla
force-pushed
the
remove/lodash-is-object-like
branch
from
June 14, 2022 08:24
e631f2b
to
f5a2eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Blocks
/packages/blocks
[Package] Core data
/packages/core-data
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
isObjectLike()
is used only a couple of times in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetch
package haslodash
as a dependency #39495How?
isObjectLike
is straightforward to replace it with atypeof value === 'object' && value !== null
. Thenull
check is needed becausetypeof null
yieldsobject
too. This PR replaces both usages.Testing Instructions
npm run test-unit packages/blocks/src/api/
core-data
utils tests pass:npm run test-unit packages/core-data/src/utils/