Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue of background min height #41693

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Fixed issue of background min height #41693

merged 6 commits into from
Jun 17, 2022

Conversation

akasunil
Copy link
Member

When a cover block uses the featured image as background image, Fixed background toggle is ON in media settings, and Minimum height of cover in back-end, Min height is getting ignored in front-end.

What?

Fixed 41660

How?

Testing Instructions

Please include step by step instructions on how to test this PR.

  1. Create a Cover block.
  2. Set the block to “Use featured image”.
  3. Turn on “Fixed background” under “Media settings”.
  4. Set a “Minimum height of cover” under “Dimensions”.
  5. View the front end page.

Screenshots

CleanShot 2022-06-13 at 20 14 09@2x

or screencast

@akasunil akasunil requested a review from ajitbohra as a code owner June 13, 2022 14:46
@akasunil akasunil mentioned this pull request Jun 15, 2022
Closed
@akasunil
Copy link
Member Author

akasunil commented Jun 16, 2022 •
edited
Loading

Can you please review the PR. @ciampo @Mamaduka

@Mamaduka Mamaduka self-requested a review June 16, 2022 05:04
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 16, 2022
@Mamaduka
Copy link
Member

Thanks for the ping, @sunil25393. I'm adding this to my to-do list.

@ciampo
Copy link
Contributor

ciampo commented Jun 17, 2022 •
edited
Loading

Hey @sunil25393 , thank you for the ping and for working on this bug fix!

I'm not the most suited person to review changes to this part of the repository, but you're going to be in good hands with @Mamaduka's review!

Mamaduka
Mamaduka approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks, @sunil25393.

@Mamaduka Mamaduka merged commit 51e09fa into WordPress:trunk Jun 17, 2022
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 17, 2022
@akasunil akasunil deleted the cover-block-fixed-background-issue branch June 17, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 13.6
Development

Successfully merging this pull request may close these issues.

Cover block HTML error using featured image, fixed background, minimum height
4 participants
@akasunil @Mamaduka @ciampo @aristath