Elements: Add UI for button elements #41659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
Global Styles
|
Size Change: -2 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
add/UI-for-block-element
branch
from
a5bdad6 to
7f74df5
Compare
draganescu
requested review from
youknowriad
and removed request for
youknowriad
draganescu
added
[Type] Enhancement
adamziel
reviewed
Jun 16, 2022
draganescu
reviewed
Jun 20, 2022
scruffian
changed the title
scruffian
changed the title
getdave
reviewed
Jun 21, 2022
getdave
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Reviewed this again but this time with Empty Theme (incidentally I notcied the reason I used TT2 on my first review was because that was shown in the demo screenrecording on the PR).
Unfortunately I still get the same results.
Screen.Capture.on.2022-06-22.at.10-26-44.mov
I believe the issue is that CSS styles are overloading the global style rules:
getdave
added
the
Needs Dev Note
|
I can't seem to dismiss my previous reviews. However, having spoken with @draganescu he's explained that #41822 actually fixes a number of the CSS specificity Issues I identified with this PR. Therefore we should wait for that PR to be merged and this PR to be rebased before attempting further reviews. |
draganescu
force-pushed
the
add/UI-for-block-element
branch
from
bcbaac4 to
1e78905
Compare
|
Thanks for picking this up and running with it @draganescu. LGTM |
getdave
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
I tested this again and it now seems to work a lot better. I can adjust both color and typography for buttons and it propagates.
Screen.Capture.on.2022-06-22.at.15-51-51.mov
This only works with Empty Theme for now because other Themes are still adding styles for button elements in CSS rather than in the new improved .json way.
Nice work 
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#41246 introduced support for the
buttonelement intheme.json. This adds a UI to make it possible to edit button elements in Global Styles.Why?
To allow users to edit their button styles.
How?
Duplicating existing global styles controls.
Testing Instructions
Screenshots or screencast
Typography
button-gs.mp4