Clarify updateNavigationLinkBlockAttributes #41657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more intuitive variable names and document an odd behavior as a docstring. Co-authored by Dave Smith <@getdave>
adamziel
added
[Block] Navigation Link
|
Size Change: +9 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Jun 14, 2022
adamziel
deleted the
refactor/navigation-link-updateNavigationLinkBlockAttributes
branch
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
@adamziel I think we won't need a dev note here as the API hasn't changed. What do you think? |
|
Yup, this changes only the implementation details @mburridge |
mburridge
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Let's use more intuitive variable names and document an odd behavior as a docstring.
Understanding that function as it stands took me and @getdave two hours. Hopefully this PR will make it easier for the next person.
Co-authored by Dave Smith <@getdave>
Testing Instructions
This is a developer experience change that shouldn't affect the logic. To test, confirm the tests are green and the logic is equivalent to how it was before this PR.