Make date picker respect site's 'Week Starts On' setting #41648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
noisysocks
requested review from
spacedmonkey,
ajitbohra and
ellatrix
as code owners
|
Size Change: +69 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Nice enhancement @noisysocks, gives the publishing interface a good additional bit of polish 👍
Works well in testing for me:
| Monday | Sunday | Wednesday (this hurts my eyes, but works!) |
|---|---|---|
 |
 |
 |
Just left an optional nit about whether we should use optional chaining 😄, but this LGTM! ✨
37 tasks
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 6, 2022
Allows the block editor to respect the site's Week Starts On setting by defining `i10n.startOfWeek` when initialising the `@wordpress/date` module. This is a backport of WordPress/gutenberg#41648. See #56467. Props andrewserong. Built from https://develop.svn.wordpress.org/trunk@54079 git-svn-id: http://core.svn.wordpress.org/trunk@53638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 6, 2022
Allows the block editor to respect the site's Week Starts On setting by defining `i10n.startOfWeek` when initialising the `@wordpress/date` module. This is a backport of WordPress/gutenberg#41648. See #56467. Props andrewserong. Built from https://develop.svn.wordpress.org/trunk@54079 git-svn-id: https://core.svn.wordpress.org/trunk@53638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne
pushed a commit
to pbearne/wordpress-develop
that referenced
this pull request
Sep 9, 2022
Allows the block editor to respect the site's Week Starts On setting by defining `i10n.startOfWeek` when initialising the `@wordpress/date` module. This is a backport of WordPress/gutenberg#41648. See #56467. Props andrewserong. git-svn-id: https://develop.svn.wordpress.org/trunk@54079 602fd350-edb4-49c9-b593-d223f7449a82
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
I don't think so, it's a bug fix. |
noisysocks
removed
the
Needs Dev Note
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
Allows the block editor to respect the site's Week Starts On setting by defining `i10n.startOfWeek` when initialising the `@wordpress/date` module. This is a backport of WordPress/gutenberg#41648. See #56467. Props andrewserong. Built from https://develop.svn.wordpress.org/trunk@54079
24 tasks
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
Allows the block editor to respect the site's Week Starts On setting by defining `i10n.startOfWeek` when initialising the `@wordpress/date` module. This is a backport of WordPress/gutenberg#41648. See #56467. Props andrewserong. git-svn-id: https://develop.svn.wordpress.org/trunk@54079 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41078.
Makes the calendar used in the post publish date picker respect the Week Starts On setting that WordPress has.
Why?
Different locales have different conventions around when the first day of the week is. Also some weirdos like me have a strong preference on the matter.
How?
The library we use for the calendar,
react-dates, already supports this setting, so I'm just passing the setting along from PHP to the component via@wordpress/datesettings which is where we put all the other locale specific date settings.Testing Instructions
Screenshots or screencast
Kapture.2022-06-10.at.15.45.03.mp4