[TypeScript] Improve type definitions in @wordpress/core-data #41593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Package] Core data
This was referenced Jun 8, 2022
adamziel
changed the title
|
Can we separate the type fixes in a distinct PR and then look at adding the |
adamziel
changed the title
|
@dmsnell done! |
|
After removing tsconfig.json this is just a small PR cleaning up more-or-less obvious typing mistakes without any runtime changes so I'll just go ahead and merge. |
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve
Exporting TypeScript type from
@wordpress/core-datarequires adding a tsconfig.json to the package. This PR prepares the type definitions so that one can be added without experiencing errors.Test plan
Confirm all checks are green – there are no runtime changes in this PR, only the type annotations are affected.
@noisysocks @sirreal @dmsnell @sarayourfriend