Add supports to basic sample code. #41589
Conversation
Like `attributes` and `save`, `supports` are not automatically inherited from the current version, so they need to be defined in some cases, but the basic sample code does not describe them, so it is difficult for beginners to understand. I think this should add a description for clarity. By the way, this page uses const to refer to the global wp object, but other pages use import statements. I feel that mixing the two could cause confusion, but should this page also be an import statement?
inc2734
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @inc2734! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Congratulations on your first merged pull request, @inc2734! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
Add supports to basic sample code.
Why?
Like
attributesandsave,supportsare not automatically inherited from the current version, so they need to be defined in some cases, but the basic sample code does not describe them, so it is difficult for beginners to understand.I think this should add a description for clarity.
By the way, this page uses const to refer to the global wp object, but other pages use import statements. I feel that mixing the two could cause confusion, but should this page also be an import statement?