Style engine: allow for zero values for CSS properties in the style engine #41561
Conversation
Create an opinionated, dedicated method so we can use it elsewhere if required.
ramonjd
added
[Type] Bug
| @@ -165,6 +184,11 @@ protected static function get_slug_from_preset_value( $style_value, $property_ke | |||
| */ | |||
| protected static function get_classnames( $style_value, $style_definition ) { | |||
| $classnames = array(); | |||
|
|
|||
| if ( empty( $style_value ) ) { | |||
There was a problem hiding this comment.
Minor question: Is it worth future-proofing this a little in case the classname generation extends beyond presets in future?
This check would still return a false positive for '0'. I'm thinking of things like the Cover blocks opacity classes like has-background-dim-0.
There was a problem hiding this comment.
That's an interesting case, thanks for raising it.
There's no requirement for such values here yet, but if we hit the cover block one day it'll be there.
I was just trying to prevent the code doing any further work for now. But there's no harm in removing the check since it wasn't there before. 👍
There was a problem hiding this comment.
| if ( empty( $style_value ) ) { | |
| if ( empty( $style_value ) && '0' !== $style_value ) { |
I was more suggesting that we tweak that check to allow '0' values rather than remove it. Sorry for the confusion.
There was a problem hiding this comment.
All good. I read the comment wrong. In that case it's probably safe to leave as it was until we get to individual blocks in 2025 😄
The fact that the style engine generates classes at all is still a bit contentious, that is, whether it should just stick to CSS.
… in generate takes care of values we don't care about.
What?
Allow for zero values for CSS properties in the style engine.
Why?
Just in case we come across a style value of
'0', e.g.,padding: '0'.This PR ensures the previous
empty()check doesn't fail for '0'.How?
Create an opinionated, dedicated method so we can use it elsewhere if required.
Testing Instructions