Components: refactor Flex to pass exhaustive-deps
#41507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xhaustive-deps` on this `useMemo` dep array due to an external dependency
chad1008
added
[Type] Code Quality
44 tasks
|
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Flexcomponent to satisfy theexhaustive-depseslint rule.Why?
Part of the effort in #41166 to apply
exhuastive-depsto the Components packageHow?
Including
rtl.watch()in the dep array can't be checked by ESLint, so we need to extract it into its own variable that can be checked.Even with that done, we need to disable
exhaustive-depshere for now, because we're relying on a value from outside of theuseEffectto trigger it, making the dependency invalid. See #41254 (review) for more context.Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/flex