-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: refactor Flex
to pass exhaustive-deps
#41507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xhaustive-deps` on this `useMemo` dep array due to an external dependency
chad1008
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
[Feature] Component System
WordPress component system
labels
Jun 2, 2022
44 tasks
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mirka
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Flex
component to satisfy theexhaustive-deps
eslint rule.Why?
Part of the effort in #41166 to apply
exhuastive-deps
to the Components packageHow?
Including
rtl.watch()
in the dep array can't be checked by ESLint, so we need to extract it into its own variable that can be checked.Even with that done, we need to disable
exhaustive-deps
here for now, because we're relying on a value from outside of theuseEffect
to trigger it, making the dependency invalid. See #41254 (review) for more context.Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/flex