Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block-Editor: Add tooltip on replace image's URL #41504

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Block-Editor: Add tooltip on replace image's URL #41504

merged 1 commit into from
Jun 5, 2022

Conversation

FilipposZ
Copy link
Contributor

@FilipposZ FilipposZ commented Jun 2, 2022 •
edited by cbravobernal
Loading

Fixes #32249

What?

Added a hover tooltip when editing an image's URL using the Replace toolbar option.

Why?

When editing an image's URL, being able to see the full URL is very important. However, the Current media URL field is far too narrow.

How?

Added a tooltip when hovering on the image's URL field displaying the full URL.

Testing Instructions

  1. Create a new post or edit an existing post
  2. Add "Image" block and select "Insert from URL" option
  3. Enter an image URL
  4. Select the "Replace" button
  5. Hover over the URL. A tooltip should appear underneath displaying the full URL of the image

Screenshot

Screenshot 2022-06-02 at 15 57 06

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @FilipposZ! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@FilipposZ FilipposZ marked this pull request as ready for review June 2, 2022 12:10
@FilipposZ FilipposZ requested a review from ellatrix as a code owner June 2, 2022 12:10
@FilipposZ FilipposZ marked this pull request as draft June 2, 2022 12:17
@cbravobernal cbravobernal added the Needs Design Needs design efforts. label Jun 2, 2022
@FilipposZ FilipposZ force-pushed the add_tooltip_on_replace_image branch from ecfeec6 to b0c1c63 Compare June 2, 2022 13:53
@FilipposZ FilipposZ force-pushed the add_tooltip_on_replace_image branch from b0c1c63 to f973e3d Compare June 2, 2022 13:54
@cbravobernal cbravobernal added the [Package] Block editor /packages/block-editor label Jun 2, 2022
@FilipposZ FilipposZ changed the title add tooltip on image replace Block-Editor: Add tooltip on replace image's URL Jun 2, 2022
@cbravobernal cbravobernal marked this pull request as ready for review June 2, 2022 15:02
@FilipposZ
Copy link
Contributor Author

Maybe @fotisps would like to give some feedback as well.

draganescu
draganescu approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense! 👏🏻 I would wait for some design feedback before merging.

@draganescu draganescu added Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media and removed Needs Design Needs design efforts. labels Jun 3, 2022
@fotisps
Copy link

fotisps commented Jun 4, 2022

Maybe @fotisps would like to give some feedback as well.

Nice one @FilipposZ ! Thanks for contributing! It's ok by me!

@richtabor
Copy link
Member

This is nice - good stuff @FilipposZ & @fotisps 👏

@cbravobernal cbravobernal merged commit ce4affa into WordPress:trunk Jun 5, 2022
@github-actions github-actions bot added this to the Gutenberg 13.5 milestone Jun 5, 2022
@FilipposZ FilipposZ deleted the add_tooltip_on_replace_image branch June 5, 2022 22:59
@cbravobernal
Copy link
Contributor

Props also to @bangank36 that helped on this PR on WCEU 2022 contributor's day! 🎉 🎉

@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 2, 2022
@femkreations femkreations mentioned this pull request Oct 3, 2022
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@cbravobernal cbravobernal Awaiting requested review from cbravobernal

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@andrewserong andrewserong Awaiting requested review from andrewserong

@richtabor richtabor Awaiting requested review from richtabor

@jameskoster jameskoster Awaiting requested review from jameskoster

@javierarce javierarce Awaiting requested review from javierarce

Assignees
No one assigned
Labels
[Feature] Media Anything that impacts the experience of managing media First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Design Feedback Needs general design feedback. Needs User Documentation Needs new user documentation [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 13.5
Development

Successfully merging this pull request may close these issues.

Image block: Replace Current media URL field too small
6 participants
@FilipposZ @fotisps @richtabor @cbravobernal @draganescu @femkreations