Migrate rtl test case to it's playwright version #41495
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pavanpatil1! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hi @kevin940726, Hope you're doing well. Could you please help me with reviewing this PR?. All test cases are passed. But seems like one End-to-End Tests / Admin - 3 CI check is failing. The error message which is shown is not related to test case which I worked upon. the error is on the test case which I haven't modified. Can you take a look at it?
|
| editor, | ||
| page, | ||
| pageUtils, | ||
| } ) => { | ||
| await page.keyboard.press( 'Enter' ); | ||
|
|
||
| // Wait for rich text editor to load. | ||
| await page.waitForSelector( '.block-editor-rich-text__editable' ); |
There was a problem hiding this comment.
Could we change this selector to something accessible? For instance, selecting it using a role selector, or replacing it along with the press( 'Enter' ) above with page.click( 'role=button[name="Add default block"i]' ).
There was a problem hiding this comment.
We still need to refactor this line to use role selectors instead though. Or maybe just remove this line if it's not doing anything meaningful now?
There was a problem hiding this comment.
Hi @kevin940726, We have refactored that line and Added the role selector
. We can't remove that line I guess.There was a problem hiding this comment.
I mean to remove this line.
await page.waitForSelector( '.block-editor-rich-text__editable' );I don't think we need it anymore?
|
Hi @kevin940726, I have addressed all the above feedback. Could you please review it again ?. Thanks!. |
|
Have you seen this comment and my latest review? :) This is very close to being merged! Thanks for the hard work! |
|
Hi @kevin940726, #41495 (comment) comment is solved here . It is not showing updated due to the selected string was different.Could you please review it again?.. |
| page, | ||
| pageUtils, | ||
| } ) => { | ||
| page.click( 'role=button[name="Add default block"i]' ); |
There was a problem hiding this comment.
| page.click( 'role=button[name="Add default block"i]' ); | |
| await page.click( 'role=button[name="Add default block"i]' ); |
|
Hi @kevin940726, Above feedbacks are addressed. Could you check once ?. |
|
Have you seen #41495 (comment) ? GitHub makes it less discoverable 😅 |
|
Hi @kevin940726, All feedbacks are addressed could you review it again ?. |
What?
Part of #38851.
Migrate rtl-test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/various/rtl.spec.js