Fixed failing DateTimePicker Unit test. #41483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
changed the title
andrewserong
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Great catch, thanks so much for fixing this @torounit!
LGTM, this updated test now matches the formatting used in the component , and the tests pass. 🎉
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
annezazu
added
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
fix: #41480
Fixed failing DateTimePicker Unit test.
Why?
Tests dependent on the current date are failing, and tests fail on all branches.
How?
Within the unit test, the month name was being retrieved as an abbreviation.
"May" seems to have passed the test because it is three characters long.
Testing Instructions