Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try/add missing typography support to button block #41435

Conversation

randhirexpresstech
Copy link
Contributor

@randhirexpresstech randhirexpresstech commented May 30, 2022

This PR adds some missing typography supports to button block, which are already available in Gutenberg.
It enables following Editor UI under typography settings

  • Line height
  • Letter spacing
  • Font style
  • Font weight

button

With the help of this PR block theme developers and website admin will have more customization options to create more beautiful website and design patterns.
In some places, designers require to have different typography as compare to global typography like font-family, font-weight, line-height etc. to create unique designs.
In the absence of these typography settings on block level, block theme developers are rely on custom css for these typography options which are not editable by website admin using frontend editor tools. So this PR will provide more flexibility and help admin to get more controls over design and UI elements.

Testing Steps

  1. Activate Twenty Twenty-Two theme
  2. Add a new page
  3. Add a button
  4. Add Line height, Letter spacing, Text transform, Font style and Font weight to the button
  5. Publish the page
  6. View and check the page for assigned typography options

Please check this screen-cast

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 30, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @randhirexpresstech! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@aaronrobertshaw
Copy link
Contributor

Hi @randhirexpresstech 👋

Thanks for putting this PR together. As discussed on #43649, there is some overlap between the styles and supports for the Buttons and Button blocks. Rather than tweaking separate PRs and wrangling them independently, I've put together an alternative PR that should help ensure we can land these features in time for the WordPress 6.1 release.

Would you mind if we closed this PR in favour of #43934?

@randhirexpresstech
Copy link
Contributor Author

Thanks @aaronrobertshaw, you can closed this PR in favour of #43934. I would be happy if we can land these features in time for the WordPress 6.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants