E2E Tests: Migrate style variations tests to Playwright #41427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Status] In Progress
ramonjd
changed the title
|
Size Change: +198 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
1cf418e
to
cf7f2bd
Compare
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
3ea7734
to
4a1b76e
Compare
ramonjd
commented
Jun 6, 2022
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
21a44a4
to
b534f82
Compare
ramonjd
commented
Jun 6, 2022
kevin940726
reviewed
Jun 6, 2022
There was a problem hiding this comment.
Thanks for starting this! Remember to checkout the best practices guide and follow them wherever possible. I think this has a great start though!
|
Thanks for helping with this one @kevin940726 !! I'm learning a lot. The first pass was just pulling everything across and getting things to work. I've added a bunch of aria-labels to navigation buttons to help tighten up the tests. There are also still a few things left to do, such as refactoring the class name assertions as you recommend, and probably inlining some more methods. I'll ping for another 👀 after I finish that if you don't mind. 🙇 |
|
🤞 I think this is in better shape @kevin940726, thanks for the pointers. Once we land #41591 I can refactor the classname assertions. |
kevin940726
reviewed
Jun 16, 2022
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
e2738ce
to
047f27c
Compare
kevin940726
reviewed
Jun 16, 2022
|
I think this is nearly ready! Thanks for your patience @kevin940726 Dismissing the styles welcome guide appears to have done the trick! |
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
fd7aae7
to
4c126e5
Compare
kevin940726
approved these changes
Jun 18, 2022
Migrating final tests and removing original
Refactoring style variations tests
Rename openOtherStyles to browseStyles Replace body.evaluate
Tidying up selectors and assertions
Dismissing Styles Welcome Guide :D
ramonjd
force-pushed
the
add/e2e-style-variation-playwright
branch
from
4c126e5
to
c697046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An attempt to chip in and migrate a playwright test.
This might go horribly wrong and blow up.
Why?
Part of the effort to move to Playwright. See: #38851
How?
Reading https://playwright.dev/docs 😄
Testing Instructions
You might have to restart wp-env after checking out this branch, then run: