-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest-console: Add types directory to "files" #41386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `types` directory won't get published to npm if we don't tell npm to include it!
noisysocks
added
[Type] Bug
An existing feature does not function as intended
[Package] Jest console
/packages/jest-console
labels
May 27, 2022
noisysocks
requested review from
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
May 27, 2022 06:38
gziolo
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do the trick 🚢
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
The `types` directory won't get published to npm if we don't tell npm to include it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Jest console
/packages/jest-console
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Includes the
types
directory in the list of files that are published to npm.Why?
So that third parties can see the TypeScript definitions included in
jest-console
. Right now nothing appears:https://unpkg.com/browse/@wordpress/[email protected]/
How?
Testing Instructions
Screenshots or screencast