Extract header used in PostVisibility and PublishDateTimePicker to a new InspectorPopoverHeader component #41362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -35 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
update/date-time-picker-design
branch
from
c79f127 to
d93ff2b
Compare
noisysocks
force-pushed
the
add/inspector-popover-header
branch
from
791d9c8 to
929d1ba
Compare
noisysocks
force-pushed
the
add/inspector-popover-header
branch
from
929d1ba to
8b4dd4d
Compare
noisysocks
added
[Feature] Document Settings
glendaviesnz
approved these changes
Jun 2, 2022
…new InspectorPopoverHeader component
noisysocks
force-pushed
the
add/inspector-popover-header
branch
from
8b4dd4d to
2f9f8df
Compare
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
I think we can probably go without as it's a fairly niche API that's marked experimental. |
noisysocks
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new
InspectorPopoverHeadercomponent which is used byPostVisibility,PublishDateTimePicker, and more to come.Why?
The headers in
PostVisibility,PublishDateTimePicker, and the popovers in the new sidebar design are identical so we should not duplicate the code.How?
The new component is in
@wordpress/block-editorso thatPublishDateTimePicker, which is used by the Post Date block, can use it. Another option is@wordpress/components(and name itPopoverHeader) but I'm not 100% convinced that this is a pattern we'll see in other parts of WordPress. It's easier to move from@wordpress/block-editor→@wordpress/componentsthan the other way around so I think best to start off here.I opted to go with
InspectorPopoverHeaderinstead ofInspectorPopoverbecause that fits in nicely with how we've organised the existing popovers which is that the content of the popover is a seperate component passed intoDropdown'srenderContent.Naming things is hard. I went with
InspectorPopoverHeaderwhich is a fairly literal description of its intended use. Open to suggestions.Testing Instructions
Screenshots or screencast