Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: refactor ColorPicker to pass exhaustive-deps #41294

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Components: refactor ColorPicker to pass exhaustive-deps #41294

merged 10 commits into from
Jul 4, 2022

Commits on Jul 4, 2022

  1. Exhaust dependencies of hooks within deprecated props hook

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9968e6b View commit details
    Browse the repository at this point in the history

  2. Exhaust dependencies of hooks in native

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    6bc7b39 View commit details
    Browse the repository at this point in the history

  3. Remove useMemos in useDeprecatedProps

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b2960dd View commit details
    Browse the repository at this point in the history

  4. Revert part of 5f6be04 in favor of a lint disable and TODO comment

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    3d56b25 View commit details
    Browse the repository at this point in the history

  5. Predetermine handling of onChange in useDeprecatedProps

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    693b8f9 View commit details
    Browse the repository at this point in the history

  6. Monopolize conditional for legacy props handling

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    d2eaf0f View commit details
    Browse the repository at this point in the history

  7. Simultaneously set internal/external color state to obviate effect

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    17787bb View commit details
    Browse the repository at this point in the history

  8. Fix oversight of potential falsy 0 values

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9942f17 View commit details
    Browse the repository at this point in the history

  9. DRYify combining hue, sat and val to hex

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    be29261 View commit details
    Browse the repository at this point in the history

  10. Add changelog entry

    @stokesman
    stokesman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1e6a2aa View commit details
    Browse the repository at this point in the history