Fix PHP 8.1 deprecation in the gallery block #41193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
force-pushed
the
fix/gallery-php81-deprecation
branch
from
dbad067 to
cab89c0
Compare
carolinan
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a PHP 8.1 deprecation error in the gallery block.
Why?
Using PHP 8.1, I'm getting the following message:
PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in gutenberg/build/block-library/blocks/gallery.php on line 51.The issue here is that PHP 8.1 is stricter than previous versions, and passing
nullwhen a string is expected is no longer acceptable. In PHP 9 this will throw a fatal error so we should fix this soon.How?
Adds an additional check to ensure that values passed to
preg_matchare strings.Testing Instructions
Using PHP 8.1 ensure that the block no longer throws a deprecation warning in the error-log.