Remove the tooltip from the block selection button #41154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
youknowriad
added
the
Good First Review
|
Size Change: +4 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed while working on #40376
What?
In "navigation mode", if you click on blocks, you'll see that the paragraph shows a title on the top left but also a tooltip underneath that title. I believe that was not intended, the tooltip is actually the aria-label which is there for screen readers but there's already the button text for visual users. So I think the tooltip was not intended there.
Testing Instructions
1- click the "select" tool from the editor header (navigation mode)
2- Click on blocks
3- The "block selection button" is shown with the block title but there's no tooltip that shows up automatically.